diff options
author | Paul Mackerras <paulus@ozlabs.org> | 2019-05-23 16:36:32 +1000 |
---|---|---|
committer | Paul Mackerras <paulus@ozlabs.org> | 2019-05-29 13:44:36 +1000 |
commit | 5a3f49364c3ffa1107bd88f8292406e98c5d206c (patch) | |
tree | eeb628b3b6b559ecec9a7ab1d4f0323ff0f31252 /drivers/watchdog/imx2_wdt.c | |
parent | 1659e27d2bc1ef47b6d031abe01b467f18cb72d9 (diff) |
KVM: PPC: Book3S HV: Don't take kvm->lock around kvm_for_each_vcpu
Currently the HV KVM code takes the kvm->lock around calls to
kvm_for_each_vcpu() and kvm_get_vcpu_by_id() (which can call
kvm_for_each_vcpu() internally). However, that leads to a lock
order inversion problem, because these are called in contexts where
the vcpu mutex is held, but the vcpu mutexes nest within kvm->lock
according to Documentation/virtual/kvm/locking.txt. Hence there
is a possibility of deadlock.
To fix this, we simply don't take the kvm->lock mutex around these
calls. This is safe because the implementations of kvm_for_each_vcpu()
and kvm_get_vcpu_by_id() have been designed to be able to be called
locklessly.
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
Diffstat (limited to 'drivers/watchdog/imx2_wdt.c')
0 files changed, 0 insertions, 0 deletions