summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/hgafb.c
diff options
context:
space:
mode:
authorKangjie Lu <kjlu@umn.edu>2019-04-01 17:46:58 +0200
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2019-04-01 17:46:58 +0200
commitec7f6aad57ad29e4e66cc2e18e1e1599ddb02542 (patch)
tree8edf09c212e2ff769f36d345702bccc4c4ebbc17 /drivers/video/fbdev/hgafb.c
parentb0e999c9558194a7b8908c41eaa7903e27fdb8c8 (diff)
video: hgafb: fix potential NULL pointer dereference
When ioremap fails, hga_vram should not be dereferenced. The fix check the failure to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu <kjlu@umn.edu> Cc: Aditya Pakki <pakki001@umn.edu> Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu> [b.zolnierkie: minor patch summary fixup] Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Diffstat (limited to 'drivers/video/fbdev/hgafb.c')
-rw-r--r--drivers/video/fbdev/hgafb.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index 463028543173..59e1cae57948 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -285,6 +285,8 @@ static int hga_card_detect(void)
hga_vram_len = 0x08000;
hga_vram = ioremap(0xb0000, hga_vram_len);
+ if (!hga_vram)
+ goto error;
if (request_region(0x3b0, 12, "hgafb"))
release_io_ports = 1;