summaryrefslogtreecommitdiff
path: root/drivers/usb
diff options
context:
space:
mode:
authorDavid Mosberger-Tang <davidm@egauge.net>2014-05-28 16:09:16 -0600
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-05-28 16:57:34 -0700
commit00c5aa178a5ba217a4143f8a5f70630550a87600 (patch)
tree48baeee19f711b8ed65883efad5f27d2ae46f16b /drivers/usb
parentff1fcd50bc2459744e6f948310bc18eb7d6e8c72 (diff)
usb: host: max3421-hcd: Fix missing unlock in max3421_urb_enqueue()
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Mosberger <davidm@egauge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/host/max3421-hcd.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index 28abda14c5e2..714f99faa14a 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -1545,8 +1545,10 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
if (!max3421_ep) {
/* gets freed in max3421_endpoint_disable: */
max3421_ep = kzalloc(sizeof(struct max3421_ep), mem_flags);
- if (!max3421_ep)
- return -ENOMEM;
+ if (!max3421_ep) {
+ retval = -ENOMEM;
+ goto out;
+ }
max3421_ep->ep = urb->ep;
max3421_ep->last_active = max3421_hcd->frame_number;
urb->ep->hcpriv = max3421_ep;
@@ -1561,6 +1563,7 @@ max3421_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
wake_up_process(max3421_hcd->spi_thread);
}
+out:
spin_unlock_irqrestore(&max3421_hcd->lock, flags);
return retval;
}