diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2021-06-18 08:15:03 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-18 13:10:02 +0200 |
| commit | 8aff64e00f1eced4e73ca81c7599c06851da4475 (patch) | |
| tree | fa2044c4c1443e3a616c2313bc3d969c4db9126f /drivers/tty | |
| parent | 007bbdc87522d17d711ca6bef0d4fe85f62f8c84 (diff) | |
mxser: don't start TX from tty_operations::put_char
TX is not supposed to be started from tty_operations::put_char. Line
disciplines ought to call tty_operations::put_char several times and
then do a single tty_operations::flush_chars to start TX.
Fix this in mxser by removing TX startup from mxser_put_char.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210618061516.662-58-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/mxser.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c index daf820c086f4..52dbdd4282b2 100644 --- a/drivers/tty/mxser.c +++ b/drivers/tty/mxser.c @@ -998,17 +998,7 @@ static int mxser_put_char(struct tty_struct *tty, unsigned char ch) info->xmit_head &= SERIAL_XMIT_SIZE - 1; info->xmit_cnt++; spin_unlock_irqrestore(&info->slock, flags); - if (!tty->flow.stopped) { - if (!tty->hw_stopped || - (info->type == PORT_16550A) || - info->board->must_hwid) { - spin_lock_irqsave(&info->slock, flags); - outb(info->IER & ~UART_IER_THRI, info->ioaddr + UART_IER); - info->IER |= UART_IER_THRI; - outb(info->IER, info->ioaddr + UART_IER); - spin_unlock_irqrestore(&info->slock, flags); - } - } + return 1; } |