summaryrefslogtreecommitdiff
path: root/drivers/tty/n_null.c
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2020-05-17 18:30:00 +0100
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2020-05-22 17:31:05 +0100
commit13e945631c2ffb946c0af342812a3cd39227de6e (patch)
tree068f1923a8fc51522491581c1cf8b1f8d8bdb4e8 /drivers/tty/n_null.c
parenta5bf6fdd19c327bcfd9073a8740fa19ca4525fd4 (diff)
iio:chemical:pms7003: Fix timestamp alignment and prevent data leak.
One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses an array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data with alignment explicitly requested. This data is allocated with kzalloc so no data can leak appart from previous readings. Fixes: a1d642266c14 ("iio: chemical: add support for Plantower PMS7003 sensor") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: <Stable@vger.kernel.org> Acked-by: Tomasz Duszynski <tomasz.duszynski@octakon.com>
Diffstat (limited to 'drivers/tty/n_null.c')
0 files changed, 0 insertions, 0 deletions