diff options
author | Stefan Wahren <stefan.wahren@i2se.com> | 2018-03-21 08:08:52 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-03-22 18:15:34 +0100 |
commit | 38861e433cf2dfb432723fb263d366534aaf9eb9 (patch) | |
tree | a9fbfe5211a0cb2f7c3f110569068be67dfd5be6 /drivers/staging/vc04_services | |
parent | 8d38bf03cb5f9209aeea710be698410ddd7a9e75 (diff) |
staging: vc04_services: Add outstanding VCHI TODOs
The TODO list missed some issues before we can move the driver out of staging.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/vc04_services')
-rw-r--r-- | drivers/staging/vc04_services/interface/vchi/TODO | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/drivers/staging/vc04_services/interface/vchi/TODO b/drivers/staging/vc04_services/interface/vchi/TODO index 84e673343bee..86708c7c8ec3 100644 --- a/drivers/staging/vc04_services/interface/vchi/TODO +++ b/drivers/staging/vc04_services/interface/vchi/TODO @@ -23,3 +23,34 @@ there's a lot code that got built that's probably unnecessary these days. Once we have the set of VCHI-using drivers we want in tree, we should be able to do a sweep of the code to see what's left that's unused. + +3) Make driver more portable + +Building this driver with arm/multi_v7_defconfig or arm64/defconfig +leads to data corruption during the following command: + + vchiq_test -f 1 + +This should be fixed. + +4) Fix kernel module support + +Even the VPU firmware doesn't support a VCHI re-connect, the driver +should properly handle a module unload. This also includes that all +resouces must be freed (kthreads, debugfs entries, ...) and global +variables avoided. + +5) Fix stack hog + +Running make checkstack shows that vchiq_dump_service_use_state() has +an extensive stack usage. Maybe other functions are also affected. + +6) Cleanup logging mechanism + +The driver should probably be using the standard kernel logging mechanisms +such as dev_info, dev_dbg, and friends. + +7) Documentation + +A short top-down description of this driver's architecture (function of +kthreads, userspace, limitations) could be very helpful for reviewers. |