summaryrefslogtreecommitdiff
path: root/drivers/staging/slicoss/slic.h
diff options
context:
space:
mode:
authorDavid Matlack <matlackdavid@gmail.com>2014-05-19 22:03:59 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-05-23 20:13:12 +0900
commit55b62cdfe9089cdaaeac52404d916cbffcfb0ab3 (patch)
tree9752672fda6c349e9db62c42317f98e3988734ba /drivers/staging/slicoss/slic.h
parentdedabbbcb5ed7c75664b4ca66a525c09fe6acf12 (diff)
staging: slicoss: fix eeprom checksum code
Rewrite slic_eeprom_cksum() to fix bugs and make readable. This patch technically has no effect on the user as failed eeprom checksums are ignored anyway. The original implementation had the following issues: 1. 2 of the 3 unrolled loops had the following bug: while ((len -= 32) >= 0) { [...] sum += w[15]; w = (u16 *)((ulong) w + 16); /* verify */ } This processes 32-bytes of data but only increments the word pointer by 16 bytes. Fixing both of these bugs seems to fix slic_eeprom_cksum(). 2. Non-descriptive variable names, use of unions, and macros that change local state make the code difficult to read. 3. The checksum loop is unrolled which makes the code harder to reason about while providing small performance improvement: - max eeprom length is 0x80 bytes (MAX_EECODE_SIZE), that's only 0x40 iterations - checksum is only computed during pci probe(), so not very often Tested on Mojave card Signed-off-by: David Matlack <matlackdavid@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/slicoss/slic.h')
0 files changed, 0 insertions, 0 deletions