summaryrefslogtreecommitdiff
path: root/drivers/staging/nvec/nvec_paz00.c
diff options
context:
space:
mode:
authorSomya Anand <somyaanand214@gmail.com>2015-03-16 19:34:11 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-16 16:28:47 +0100
commit4c42d979816a0bc1d87aaabc4089d857942ddfe2 (patch)
treef572c1fd88c7a97db7e6e0b99c9117dc2cd5aec3 /drivers/staging/nvec/nvec_paz00.c
parent6e3f3bb8631600ffc5788a4e9476ea841feac964 (diff)
Staging: nvec: use !x instead of x == NULL
Functions like devm_kzalloc, kmalloc_array, devm_ioremap, usb_alloc_urb, alloc_netdev return NULL as a return value on failure. Generally, When NULL represents failure, !x is commonly used. This patch cleans up the tests on the results of these functions, thereby using !x instead of x == NULL or NULL == x. This is done via following coccinelle script: @prob_7@ identifier x; statement S; @@ ( x = devm_kzalloc(...); | x = usb_alloc_urb(...); | x = kmalloc_array(...); | x = devm_ioremap(...); | x = alloc_netdev(...); ) ... - if(NULL == x) + if(!x) S Further we have used isomorphism characteristics of coccinelle to indicate x == NULL and NULL == x are equivalent. This is done via following iso script. Expression @ is_null @ expression X; @@ X == NULL <=> NULL == X Signed-off-by: Somya Anand <somyaanand214@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/nvec/nvec_paz00.c')
-rw-r--r--drivers/staging/nvec/nvec_paz00.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index f0cea0e43c96..68146bfee2b3 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -51,7 +51,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
int ret = 0;
led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
- if (led == NULL)
+ if (!led)
return -ENOMEM;
led->cdev.max_brightness = NVEC_LED_MAX;