diff options
| author | Johan Hovold <johan@hovoldconsulting.com> | 2016-01-29 15:42:31 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@google.com> | 2016-02-01 17:52:20 -0800 |
| commit | 8ec589b9796eebfa266d2b047ee2318541814e28 (patch) | |
| tree | 6e4b821bd77f9a507bc7e1ebaabf5c5e038038f6 /drivers/staging/greybus/firmware.h | |
| parent | c760442e1cafef30de20ea5b64074d70efa6eec2 (diff) | |
greybus: firmware: convert to bundle driver
Convert the legacy firmware protocol driver to a bundle driver.
This also fixes a potential crash should a (malicious) module have sent
an early request before the private data had been initialised.
Note that the firmware protocol needs to support the version request
indefinitely since it has been burnt into ROM.
In order to avoid having to update current module-loading scripts, keep
this driver internal to greybus core at least until modalias support is
added.
Note that there is no MODULE_DEVICE_TABLE defined for firmware as we
cannot have two greybus tables in one module on ancient 3.10 kernels and
that the legacy driver is currently also internal to core. This needs be
added once the driver can be built as a module.
Testing Done: Tested on DB3.
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/firmware.h')
| -rw-r--r-- | drivers/staging/greybus/firmware.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h index 548d297eec63..f25744c1648e 100644 --- a/drivers/staging/greybus/firmware.h +++ b/drivers/staging/greybus/firmware.h @@ -10,7 +10,7 @@ #ifndef __FIRMWARE_H #define __FIRMWARE_H -int gb_firmware_protocol_init(void); -void gb_firmware_protocol_exit(void); +int gb_firmware_init(void); +void gb_firmware_exit(void); #endif /* __FIRMWARE_H */ |