diff options
author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2015-02-26 09:55:03 +0100 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2015-03-06 12:30:23 -0600 |
commit | a1b7f2f6367944d445c6853035830a35c6343939 (patch) | |
tree | 2e6f5112ff81f65cbcae5490988ce1724ec5fe90 /drivers/spi/spi-bcm53xx.h | |
parent | a43f32d647273023edddb0dc8f91c4c6378b252b (diff) |
PCI/AER: Avoid info leak in __print_tlp_header()
Commit fab4c256a58b ("PCI/AER: Add a TLP header print helper") introduced
the helper function __print_tlp_header(), but contrary to the intention,
the behaviour did change: Since we're taking the address of the parameter
t, the first 4 or 8 bytes printed will be the value of the pointer t
itself, and the remaining 12 or 8 bytes will be who-knows-what (something
from the stack).
We want to show the values of the four members of the struct
aer_header_log_regs; that can be done without ugly and error-prone casts.
On little-endian this should produce the same output as originally
intended, and since no-one has complained about getting garbage output so
far, I think big-endian should be ok too.
Fixes: fab4c256a58b ("PCI/AER: Add a TLP header print helper")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Borislav Petkov <bp@suse.de>
CC: stable@vger.kernel.org # v3.14+
Diffstat (limited to 'drivers/spi/spi-bcm53xx.h')
0 files changed, 0 insertions, 0 deletions