diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:54:30 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-09-27 09:59:16 +0200 |
commit | 31aefe14bc9f56566041303d733fda511d3a1c3e (patch) | |
tree | c300d9019ea60df9f8ac97e35c1bce93f68a9ce6 /drivers/soundwire | |
parent | 424adc329bcbf3bfad80a6b01cffe5f2ee5080a1 (diff) |
net: aquantia: Fix aq_vec_isr_legacy() return value
The irqreturn_t type is an enum or an unsigned int in GCC. That
creates to problems because it can't detect if the
self->aq_hw_ops->hw_irq_read() call fails and at the end the function
always returns IRQ_HANDLED.
drivers/net/ethernet/aquantia/atlantic/aq_vec.c:316 aq_vec_isr_legacy() warn: unsigned 'err' is never less than zero.
drivers/net/ethernet/aquantia/atlantic/aq_vec.c:329 aq_vec_isr_legacy() warn: always true condition '(err >= 0) => (0-u32max >= 0)'
Fixes: 970a2e9864b0 ("net: ethernet: aquantia: Vector operations")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/soundwire')
0 files changed, 0 insertions, 0 deletions