summaryrefslogtreecommitdiff
path: root/drivers/sn
diff options
context:
space:
mode:
authorAnton Vorontsov <avorontsov@ru.mvista.com>2009-10-12 06:00:26 +0000
committerDavid S. Miller <davem@davemloft.net>2009-10-12 23:54:01 -0700
commitccc05c6e1e4fb672c93c98d92079c89a976e80ba (patch)
treef687178656c4d0b42f45a5b1648569c650c5617e /drivers/sn
parenta2e2725541fad72416326798c2d7fa4dafb7d337 (diff)
gianfar: Some cleanups for startup_gfar()
We're going to split the startup_gfar() into 3 separate functions, so let's cleanup the code a little bit so that cosmetic changes won't distract attention from logical ones. - Remove needless casts (e.g. (struct sk_buff **)kmalloc()); - Turn 'unsigned long vaddr;' into 'void *vaddr', to avoid casting; - Add new 'struct device *dev' variable as a shorthand for '&priv->ofdev->dev' that is used all over the place, also rename 'struct net_device *dev' to 'struct net_device *ndev'; - Turn printk(KERN_ERR ...) to pr_err(...), which is shorter; - Don't return bogus -1 (i.e. -EPERM) when request_irq() fails; - Turn '&priv->regs->' to just '&regs->'. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/sn')
0 files changed, 0 insertions, 0 deletions