summaryrefslogtreecommitdiff
path: root/drivers/power
diff options
context:
space:
mode:
authorNiklas Cassel <nks@flawful.org>2019-12-23 15:19:31 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2019-12-29 22:11:22 +0100
commitcad12cdeea783e8b7fc4425848028d3606a4cba8 (patch)
tree2c821dd6f3635aa63da8414da4f1f8f69e21211d /drivers/power
parente808926b4dd1e1f1d3c842c1f6f2aae7c72543ae (diff)
power: avs: qcom-cpr: fix unsigned expression compared with zero
drivers/power/avs/qcom-cpr.c:1539:5-21: warning: unsigned expression compared with zero: drv->num_corners < 0 Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Niklas Cassel <nks@flawful.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/power')
-rw-r--r--drivers/power/avs/qcom-cpr.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index a52d2cef1300..232836a1ef27 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -1535,11 +1535,13 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
* The reason for this is that we need to know the highest
* frequency associated with each fuse corner.
*/
- drv->num_corners = dev_pm_opp_get_opp_count(&drv->pd.dev);
- if (drv->num_corners < 0) {
- ret = drv->num_corners;
+ ret = dev_pm_opp_get_opp_count(&drv->pd.dev);
+ if (ret < 0) {
+ dev_err(drv->dev, "could not get OPP count\n");
goto unlock;
}
+ drv->num_corners = ret;
+
if (drv->num_corners < 2) {
dev_err(drv->dev, "need at least 2 OPPs to use CPR\n");
ret = -EINVAL;