diff options
| author | Nishka Dasgupta <nishkadg.linux@gmail.com> | 2019-08-04 21:21:17 +0530 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2019-08-06 14:51:13 +0200 |
| commit | ea8cf5c518502a12cb5bab935fd7bc152822e520 (patch) | |
| tree | e974b2f42703544f8adef014c6dd633d57b02359 /drivers/pinctrl | |
| parent | f17d2f54d36dd316bcff4e619a1a349f04214a83 (diff) | |
pinctrl: nomadik: nomadik: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804155117.4753-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index ddd1f466d302..2a8190b11d10 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1508,6 +1508,7 @@ static int nmk_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); + of_node_put(np); return ret; } } |