diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-07-02 13:47:08 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2018-07-02 16:05:01 +0200 |
| commit | 23ee0f192033ac6742fc179699d91336a000aef5 (patch) | |
| tree | 9a604c2f387cdf6252eb5fe8276155f295f1d1bd /drivers/pinctrl/actions | |
| parent | 875a92b3f58a117842c0f9e8d65355c6be218fa2 (diff) | |
pinctrl: actions: fix unsigned less than zero comparison
The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero. Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.
Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")
Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/actions')
| -rw-r--r-- | drivers/pinctrl/actions/pinctrl-owl.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/pinctrl/actions/pinctrl-owl.c b/drivers/pinctrl/actions/pinctrl-owl.c index ce032d71dad5..6b89b2b41316 100644 --- a/drivers/pinctrl/actions/pinctrl-owl.c +++ b/drivers/pinctrl/actions/pinctrl-owl.c @@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev, } for (i = 0; i < pctrl->num_irq ; i++) { - pctrl->irq[i] = platform_get_irq(pdev, i); - if (pctrl->irq[i] < 0) { - ret = pctrl->irq[i]; + ret = platform_get_irq(pdev, i); + if (ret < 0) goto err_exit; - } + pctrl->irq[i] = ret; } ret = owl_gpio_init(pctrl); |