diff options
author | Eric Dumazet <edumazet@google.com> | 2013-05-15 15:38:01 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-05-16 14:43:40 -0700 |
commit | 6ff50cd55545d922f5c62776fe1feb38a9846168 (patch) | |
tree | cf3a50a628e14fe105a04050823e3051aebf92f3 /drivers/net | |
parent | 5c4b274981950049af3330f14ed9e9aa25afb2fb (diff) |
tcp: gso: do not generate out of order packets
GSO TCP handler has following issues :
1) ooo_okay from original GSO packet is duplicated to all segments
2) segments (but the last one) are orphaned, so transmit path can not
get transmit queue number from the socket. This happens if GSO
segmentation is done before stacked device for example.
Result is we can send packets from a given TCP flow to different TX
queues (if using multiqueue NICS). This generates OOO problems and
spurious SACK & retransmits.
Fix this by keeping socket pointer set for all segments.
This means that every segment must also have a destructor, and the
original gso skb truesize must be split on all segments, to keep
precise sk->sk_wmem_alloc accounting.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions