summaryrefslogtreecommitdiff
path: root/drivers/net/phy/sfp.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-06-13 09:51:02 +0300
committerDavid S. Miller <davem@davemloft.net>2019-06-14 19:21:31 -0700
commit1086ca3a63a3af6b8a722fff55da46f111bc40ee (patch)
tree61d409950eaa4ace161621b97a0b172de4dafe2f /drivers/net/phy/sfp.c
parentd5afa82c977ea06f7119058fa0eb8519ea501031 (diff)
net: phy: sfp: clean up a condition
The acpi_node_get_property_reference() doesn't return ACPI error codes, it just returns regular negative kernel error codes. This patch doesn't affect run time, it's just a clean up. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Ruslan Babayev <ruslan@babayev.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/sfp.c')
-rw-r--r--drivers/net/phy/sfp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 97960d73b4ab..2d816aadea79 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -1848,7 +1848,7 @@ static int sfp_probe(struct platform_device *pdev)
int ret;
ret = acpi_node_get_property_reference(fw, "i2c-bus", 0, &args);
- if (ACPI_FAILURE(ret) || !is_acpi_device_node(args.fwnode)) {
+ if (ret || !is_acpi_device_node(args.fwnode)) {
dev_err(&pdev->dev, "missing 'i2c-bus' property\n");
return -ENODEV;
}