diff options
| author | Russell King <rmk+kernel@armlinux.org.uk> | 2018-01-05 16:07:10 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-01-08 14:20:21 -0500 |
| commit | f102852f980eac250855504c18f195900616deec (patch) | |
| tree | b732623e465dfbea31110fe84ebf2fcb3b73210f /drivers/net/phy/phy-core.c | |
| parent | 64f26abb17ca2e55ab584352ca4d68cf42c8c102 (diff) | |
net: phy: fix wrong masks to phy_modify()
The mask argument for phy_modify() in several locations was inverted.
Fixes: fea23fb591cc ("net: phy: convert read-modify-write to phy_modify()")
Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/phy-core.c')
| -rw-r--r-- | drivers/net/phy/phy-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy-core.c b/drivers/net/phy/phy-core.c index 44d09b192014..e75989ce8850 100644 --- a/drivers/net/phy/phy-core.c +++ b/drivers/net/phy/phy-core.c @@ -332,7 +332,7 @@ EXPORT_SYMBOL(phy_write_mmd); * @set: bit mask of bits to set * * Unlocked helper function which allows a PHY register to be modified as - * new register value = (old register value & mask) | set + * new register value = (old register value & ~mask) | set */ int __phy_modify(struct phy_device *phydev, u32 regnum, u16 mask, u16 set) { |