summaryrefslogtreecommitdiff
path: root/drivers/media/pci/saa7134/saa7134-ts.c
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2014-04-17 07:24:31 -0300
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-05-13 13:23:41 -0300
commit17e7f1b515803e1a79b246688aacbddd2e34165d (patch)
tree0919ddfe8ec0c747b2b6d73098d7eae4f7fa43fd /drivers/media/pci/saa7134/saa7134-ts.c
parent393cbd8dc532c1ebed60719da8d379f50d445f28 (diff)
[media] saa7134: fix regression with tvtime
This solves this bug: https://bugzilla.kernel.org/show_bug.cgi?id=73361 The problem is that when you quit tvtime it calls STREAMOFF, but then it queues a bunch of buffers for no good reason before closing the file descriptor. In the past closing the fd would free the vb queue since that was part of the file handle struct. Since that was moved to the global struct that no longer happened. This wouldn't be a problem, but the extra QBUF calls that tvtime does meant that the buffer list in videobuf (q->stream) contained buffers, so REQBUFS would fail with -EBUSY. The solution is to init the list head explicitly when releasing the file descriptor and to not free the video resource when calling streamoff. The real fix will hopefully go into kernel 3.16 when the vb2 conversion is merged. Basically the saa7134 driver with the old videobuf is so full of holes it ain't funny anymore, so consider this a band-aid for kernels 3.14 and 15. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: stable@vger.kernel.org # for v3.14 and up Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'drivers/media/pci/saa7134/saa7134-ts.c')
0 files changed, 0 insertions, 0 deletions