diff options
| author | Malcolm Priestley <tvboxspy@gmail.com> | 2012-08-13 14:42:17 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-08-13 19:53:29 -0300 |
| commit | 0a67fe458471cc13adeb0e10694e10674bf383eb (patch) | |
| tree | 3fb4dfdcbb016d0be5245f34293c97ba387083e0 /drivers/media/dvb/dvb-usb-v2 | |
| parent | ae53020527796a123e61698160b3cf193ce8cf48 (diff) | |
[media] lmedm04: fix data usage past the end of the buffer
On Mon, 2012-08-13 at 19:58 +0300, Dan Carpenter wrote:
> Hello Mauro Carvalho Chehab,
>
> The patch db6651a9ebb3: "[media] lmedm04: fix build" from Aug 12,
> 2012, leads to the following warning:
> drivers/media/dvb/dvb-usb-v2/lmedm04.c:769 lme2510_download_firmware()
> error: usb_control_msg() 'data' too small (128 vs 265)
>
> 737 data = kzalloc(128, GFP_KERNEL);
> ^^^
> data is 128 bytes.
Control isn't used, so remove it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/dvb/dvb-usb-v2')
| -rw-r--r-- | drivers/media/dvb/dvb-usb-v2/lmedm04.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/media/dvb/dvb-usb-v2/lmedm04.c b/drivers/media/dvb/dvb-usb-v2/lmedm04.c index c6bc1b8b58b8..c41d9d9ec7b5 100644 --- a/drivers/media/dvb/dvb-usb-v2/lmedm04.c +++ b/drivers/media/dvb/dvb-usb-v2/lmedm04.c @@ -766,10 +766,6 @@ static int lme2510_download_firmware(struct dvb_usb_device *d, } } - usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0), - 0x06, 0x80, 0x0200, 0x00, data, 0x0109, 1000); - - data[0] = 0x8a; len_in = 1; msleep(2000); |