diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-04-07 03:11:37 +0000 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-04-08 22:47:48 +0200 |
| commit | 3ab4ce2daf09b62e38934a7afe3e9fc3f3cbcdec (patch) | |
| tree | 8ca7d6daa7c12eef6aabc362a2e9ce4c573505e3 /drivers/i2c/busses | |
| parent | 010e32ab205bfee3a3e860d0366c1516c3e298f9 (diff) | |
i2c: designware: Fix return value check in navi_amd_register_client()
In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Fixes: 17631e8ca2d3 ("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses')
| -rw-r--r-- | drivers/i2c/busses/i2c-designware-pcidrv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 7ca0017883a6..0f409a4c2da0 100644 --- a/drivers/i2c/busses/i2c-designware-pcidrv.c +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c @@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev) info.irq = dev->irq; dev->slave = i2c_new_client_device(&dev->adapter, &info); - if (!dev->slave) - return -ENODEV; + if (IS_ERR(dev->slave)) + return PTR_ERR(dev->slave); return 0; } |