diff options
| author | Tomasz Figa <tfiga@chromium.org> | 2018-04-23 12:50:01 +0200 |
|---|---|---|
| committer | Andrzej Hajda <a.hajda@samsung.com> | 2018-04-24 08:34:52 +0200 |
| commit | 6e6cf3e2f2651c24c121aaba63f591166a9957dc (patch) | |
| tree | 2169b438aef2f8f05abeaa360faef85fd677af29 /drivers/gpu/drm/rockchip/rockchip_drm_vop.c | |
| parent | 39b138ea861a3494d2962467d6e275ae9f80a364 (diff) | |
drm/rockchip: psr: Sanitize semantics of allow/inhibit API
Currently both rockchip_drm_psr_activate() and _deactivate() only set the
boolean "active" flag without actually making sure that hardware state
complies with it.
Since we are going to extend the usage of this API to properly lock PSR
for the duration of atomic commits, we change the semantics in following
way:
- a counter is used to track the number of inhibit requests,
- PSR is actually disabled in hardware on first inhibit request,
- PSR enable work is scheduled on last allow request.
The above allows using the API as a way to deterministically synchronize
PSR state changes with other DRM events, i.e. atomic commits and cursor
updates. As a nice side effect, the naming is sorted out and we have
"inhibit" for stopping the software logic and "enable" for hardware
state.
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180423105003.9004-26-enric.balletbo@collabora.com
Diffstat (limited to 'drivers/gpu/drm/rockchip/rockchip_drm_vop.c')
0 files changed, 0 insertions, 0 deletions