diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2021-05-19 14:16:50 +0000 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2021-05-28 15:11:44 +0800 |
| commit | 5c0ecc2e81ecfd9eba8a4945d49c401615c167ca (patch) | |
| tree | 444a59eaa47dc4d38852685cfee881567bcf9783 /drivers/crypto | |
| parent | 308365483351fad2c2c15e173df60c7168c828a5 (diff) | |
crypto: qce - Fix some error handling path
Fix to return negative error code from the error handling
cases instead of 0.
Fixes: 9363efb4181c ("crypto: qce - Add support for AEAD algorithms")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/qce/aead.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/drivers/crypto/qce/aead.c b/drivers/crypto/qce/aead.c index 6d06a19b48e4..d47f4171ad83 100644 --- a/drivers/crypto/qce/aead.c +++ b/drivers/crypto/qce/aead.c @@ -280,8 +280,10 @@ qce_aead_ccm_prepare_buf_assoclen(struct aead_request *req) if (diff_dst) { sg = qce_aead_prepare_dst_buf(req); - if (IS_ERR(sg)) + if (IS_ERR(sg)) { + ret = PTR_ERR(sg); goto err_free; + } } else { if (IS_ENCRYPT(rctx->flags)) rctx->dst_nents = rctx->src_nents + 1; @@ -448,13 +450,17 @@ qce_aead_async_req_handle(struct crypto_async_request *async_req) if (ret) return ret; dst_nents = dma_map_sg(qce->dev, rctx->dst_sg, rctx->dst_nents, dir_dst); - if (dst_nents < 0) + if (dst_nents < 0) { + ret = dst_nents; goto error_free; + } if (diff_dst) { src_nents = dma_map_sg(qce->dev, rctx->src_sg, rctx->src_nents, dir_src); - if (src_nents < 0) + if (src_nents < 0) { + ret = src_nents; goto error_unmap_dst; + } } else { if (IS_CCM(rctx->flags) && IS_DECRYPT(rctx->flags)) src_nents = dst_nents; |