diff options
| author | Keith Busch <kbusch@kernel.org> | 2019-10-10 00:38:13 +0900 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-10-09 21:00:20 -0600 |
| commit | 79a85e214d62da9a750cc63ef49483e62abbda81 (patch) | |
| tree | 2949c2de17ef47047ab7d6447c29c8b433fe3053 /drivers/block | |
| parent | 8a99734081775c012a4a6c442fdef0379fe52bdf (diff) | |
null_blk: Fix zoned command return code
The return code from null_handle_zoned() sets the cmd->error value.
Returning OK status when an error occured overwrites the intended
cmd->error. Return the appropriate error code instead of setting the
error in the cmd.
Fixes: fceb5d1b19cbe626 ("null_blk: create a helper for zoned devices")
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/null_blk_zoned.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/block/null_blk_zoned.c b/drivers/block/null_blk_zoned.c index eabc116832a7..3d7fdea872f8 100644 --- a/drivers/block/null_blk_zoned.c +++ b/drivers/block/null_blk_zoned.c @@ -142,8 +142,7 @@ static blk_status_t null_zone_reset(struct nullb_cmd *cmd, sector_t sector) zone->wp = zone->start; break; default: - cmd->error = BLK_STS_NOTSUPP; - break; + return BLK_STS_NOTSUPP; } return BLK_STS_OK; } |