diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2021-06-16 11:27:44 +0200 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2021-06-16 13:55:05 -0600 |
| commit | 2892d8a00d23d511a0591ac4b2ff3f050ae1f004 (patch) | |
| tree | 920de694fb3510000daff64fbb9bb57133ba9249 /drivers/ata/ahci_brcm.c | |
| parent | 90b8cadfe447d7299c7061b07d50da5a6160bcc5 (diff) | |
of: Fix truncation of memory sizes on 32-bit platforms
Variable "size" has type "phys_addr_t", which can be either 32-bit or
64-bit on 32-bit systems, while "unsigned long" is always 32-bit on
32-bit systems. Hence the cast in
(unsigned long)size / SZ_1M
may truncate a 64-bit size to 32-bit, as casts have a higher operator
precedence than divisions.
Fix this by inverting the order of the cast and division, which should
be safe for memory blocks smaller than 4 PiB. Note that the division is
actually a shift, as SZ_1M is a power-of-two constant, hence there is no
need to use div_u64().
While at it, use "%lu" to format "unsigned long".
Fixes: e8d9d1f5485b52ec ("drivers: of: add initialization code for static reserved memory")
Fixes: 3f0c8206644836e4 ("drivers: of: add initialization code for dynamic reserved memory")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/4a1117e72d13d26126f57be034c20dac02f1e915.1623835273.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/ata/ahci_brcm.c')
0 files changed, 0 insertions, 0 deletions