summaryrefslogtreecommitdiff
path: root/drivers/acpi/ioapic.c
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-09-06 13:05:48 -0700
committerKalle Valo <kvalo@codeaurora.org>2020-09-09 10:30:28 +0300
commiteb2c6ca2db8c9cf112f0b604c1edfe21b5725f17 (patch)
tree6b9c045346d440a6a5f37d82aa5a4fbe8f50050b /drivers/acpi/ioapic.c
parent86279456a4d47782398d3cb8193f78f672e36cac (diff)
mwifiex: remove function pointer check
clang static analyzer reports this problem init.c:739:8: warning: Called function pointer is null (null dereference) ret = adapter->if_ops.check_fw_status( ... ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In mwifiex_dnld_fw, there is an earlier check for check_fw_status(), The check was introduced for usb support at the same time this check in _mwifiex_fw_dpc() was made if (adapter->if_ops.dnld_fw) { ret = adapter->if_ops.dnld_fw(adapter, &fw); } else { ret = mwifiex_dnld_fw(adapter, &fw); } And a dnld_fw function initialized as part the usb's mwifiex_if_ops. The other instances of mwifiex_if_ops for pci and sdio both set check_fw_status. So the first check is not needed and can be removed. Fixes: 4daffe354366 ("mwifiex: add support for Marvell USB8797 chipset") Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20200906200548.18053-1-trix@redhat.com
Diffstat (limited to 'drivers/acpi/ioapic.c')
0 files changed, 0 insertions, 0 deletions