summaryrefslogtreecommitdiff
path: root/drivers/Makefile
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2016-11-28 16:17:41 -0600
committerBjorn Helgaas <bhelgaas@google.com>2016-11-29 18:05:09 -0600
commit0b457dde3cf8b7c76a60f8e960f21bbd4abdc416 (patch)
tree03d45576b49ce2763b718986b925f77ead34f79d /drivers/Makefile
parent7a6d312b50e63f598f5b5914c4fd21878ac2b595 (diff)
PCI: Add comments about ROM BAR updating
pci_update_resource() updates a hardware BAR so its address matches the kernel's struct resource UNLESS it's a disabled ROM BAR. We only update those when we enable the ROM. It's not obvious from the code why ROM BARs should be handled specially. Apparently there are Matrox devices with defective ROM BARs that read as zero when disabled. That means that if pci_enable_rom() reads the disabled BAR, sets PCI_ROM_ADDRESS_ENABLE (without re-inserting the address), and writes it back, it would enable the ROM at address zero. Add comments and references to explain why we can't make the code look more rational. The code changes are from 755528c860b0 ("Ignore disabled ROM resources at setup") and 8085ce084c0f ("[PATCH] Fix PCI ROM mapping"). Link: https://lkml.org/lkml/2005/8/30/138 Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Diffstat (limited to 'drivers/Makefile')
0 files changed, 0 insertions, 0 deletions