summaryrefslogtreecommitdiff
path: root/crypto/geniv.c
diff options
context:
space:
mode:
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>2020-11-17 12:40:54 +0300
committerMark Brown <broonie@kernel.org>2020-11-17 17:08:39 +0000
commita41b0ad07bfa081584218431cb0cd7e7ecc71210 (patch)
tree1820a56891a5bdd77b8b6eb8e82e09ae9fe1f6e8 /crypto/geniv.c
parentac9978fcad3c5abc43cdd225441ce9459c36e16b (diff)
spi: dw: Set transfer handler before unmasking the IRQs
It turns out the IRQs most like can be unmasked before the controller is enabled with no problematic consequences. The manual doesn't explicitly state that, but the examples perform the controller initialization procedure in that order. So the commit da8f58909e7e ("spi: dw: Unmask IRQs after enabling the chip") hasn't been that required as I thought. But anyway setting the IRQs up after the chip enabling still worth adding since it has simplified the code a bit. The problem is that it has introduced a potential bug. The transfer handler pointer is now initialized after the IRQs are enabled. That may and eventually will cause an invalid or uninitialized callback invocation. Fix that just by performing the callback initialization before the IRQ unmask procedure. Fixes: da8f58909e7e ("spi: dw: Unmask IRQs after enabling the chip") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Link: https://lore.kernel.org/r/20201117094054.4696-1-Sergey.Semin@baikalelectronics.ru Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'crypto/geniv.c')
0 files changed, 0 insertions, 0 deletions