diff options
author | Eric Dumazet <edumazet@google.com> | 2018-09-27 09:32:01 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-09-28 11:12:29 -0700 |
commit | 0c3b9d1b37df16ae6046a5a01f769bf3d21b838c (patch) | |
tree | e58ffe301d2056d8e4f1ea934febea418573c8e4 /crypto/ahash.c | |
parent | a4f570be654de779eaf626a79c4e0aa5a790505f (diff) |
ibmvnic: remove ndo_poll_controller
As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.
ibmvnic uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.
ibmvnic_netpoll_controller() was completely wrong anyway,
as it was scheduling NAPI to service RX queues (instead of TX),
so I doubt netpoll ever worked on this driver.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Cc: John Allen <jallen@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto/ahash.c')
0 files changed, 0 insertions, 0 deletions