summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorStephen Douthit <stephend@adiengineering.com>2017-08-07 17:10:59 -0400
committerWolfram Sang <wsa@the-dreams.de>2017-08-29 22:12:30 +0200
commitb6c159a9cb69c2cf0bf59d4e12c3a2da77e4d994 (patch)
tree779a14fa4036990b8ca73e0d87bffc306703ba60 /block
parentcc4a41fe5541a73019a864883297bd5043aa6d98 (diff)
i2c: ismt: Don't duplicate the receive length for block reads
According to Table 15-14 of the C2000 EDS (Intel doc #510524) the rx data pointed to by the descriptor dptr contains the byte count. desc->rxbytes reports all bytes read on the wire, including the "byte count" byte. So if a device sends 4 bytes in response to a block read, on the wire and in the DMA buffer we see: count data1 data2 data3 data4 0x04 0xde 0xad 0xbe 0xef That's what we want to return in data->block to the next level. Instead we were actually prefixing that with desc->rxbytes: bad count count data1 data2 data3 data4 0x05 0x04 0xde 0xad 0xbe 0xef This was discovered while developing a BMC solution relying on the ipmi_ssif.c driver which was trying to interpret the bogus length field as part of the IPMI response. Signed-off-by: Stephen Douthit <stephend@adiengineering.com> Tested-by: Dan Priamo <danp@adiengineering.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Cc: stable@kernel.org
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions