diff options
author | Russell King <rmk+kernel@armlinux.org.uk> | 2017-03-31 10:37:07 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-04-01 20:04:03 -0700 |
commit | 83ea067fe2eae9a67c172aede6e11b9f194b1d52 (patch) | |
tree | 10095086ecdfaf4fb333f79eb6f15bee68ce3ad3 /block | |
parent | eefe06e8ceea88f8397a8df0880ab5ca28dcada6 (diff) |
net: phy: avoid setting unsupported EEE advertisments
We currently allow userspace to set any EEE advertisments it desires,
whether or not the PHY supports them. For example:
# ethtool --set-eee eth1 advertise 0xffffffff
# ethtool --show-eee eth1
EEE Settings for eth1:
EEE status: disabled
Tx LPI: disabled
Supported EEE link modes: 100baseT/Full
1000baseT/Full
10000baseT/Full
Advertised EEE link modes: 100baseT/Full
1000baseT/Full
1000baseKX/Full
10000baseT/Full
10000baseKX4/Full
10000baseKR/Full
Clearly, this is not sane, we should only allow link modes that are
supported to be advertised (as we do elsewhere.) Ensure that we mask
the MDIO_AN_EEE_ADV value with the capabilities retrieved from the
MDIO_PCS_EEE_ABLE register.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions