diff options
| author | Dmitry V. Levin <ldv@altlinux.org> | 2019-07-14 19:20:47 +0300 |
|---|---|---|
| committer | Christian Brauner <christian@brauner.io> | 2019-07-14 20:36:12 +0200 |
| commit | 028b6e8a89de9133a869bb4cd1bc72445b1ec8ca (patch) | |
| tree | 1f7464eb4b1f64d20def0019a2818e8c3e9c2c74 /arch | |
| parent | 964a4eacef67503a1154f7e0a75f52fbdce52022 (diff) | |
clone: fix CLONE_PIDFD support
The introduction of clone3 syscall accidentally broke CLONE_PIDFD
support in traditional clone syscall on compat x86 and those
architectures that use do_fork to implement clone syscall.
This bug was found by strace test suite.
Link: https://strace.io/logs/strace/2019-07-12
Fixes: 7f192e3cd316 ("fork: add clone3")
Bisected-and-tested-by: Anatoly Pugachev <matorola@gmail.com>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Link: https://lore.kernel.org/r/20190714162047.GB10389@altlinux.org
Signed-off-by: Christian Brauner <christian@brauner.io>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/ia32/sys_ia32.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/x86/ia32/sys_ia32.c b/arch/x86/ia32/sys_ia32.c index 64a6c952091e..21790307121e 100644 --- a/arch/x86/ia32/sys_ia32.c +++ b/arch/x86/ia32/sys_ia32.c @@ -239,6 +239,7 @@ COMPAT_SYSCALL_DEFINE5(x86_clone, unsigned long, clone_flags, { struct kernel_clone_args args = { .flags = (clone_flags & ~CSIGNAL), + .pidfd = parent_tidptr, .child_tid = child_tidptr, .parent_tid = parent_tidptr, .exit_signal = (clone_flags & CSIGNAL), @@ -246,5 +247,8 @@ COMPAT_SYSCALL_DEFINE5(x86_clone, unsigned long, clone_flags, .tls = tls_val, }; + if (!legacy_clone_args_valid(&args)) + return -EINVAL; + return _do_fork(&args); } |