diff options
author | John Fastabend <john.fastabend@gmail.com> | 2020-06-22 20:22:23 -0700 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2020-06-24 00:04:36 +0200 |
commit | 2fde1747c986cac28fa66d0cffd7577db042640b (patch) | |
tree | b63ed51d2ae66d7a8aea24308b6de2041440c8e9 /arch/sh | |
parent | 5e85c6bb8e74bd9daa4f5815da373d4ac2cb1a35 (diff) |
selftests/bpf: Add variable-length data concat pattern less than test
Extend original variable-length tests with a case to catch a common
existing pattern of testing for < 0 for errors. Note because
verifier also tracks upper bounds and we know it can not be greater
than MAX_LEN here we can skip upper bound check.
In ALU64 enabled compilation converting from long->int return types
in probe helpers results in extra instruction pattern, <<= 32, s >>= 32.
The trade-off is the non-ALU64 case works. If you really care about
every extra insn (XDP case?) then you probably should be using original
int type.
In addition adding a sext insn to bpf might help the verifier in the
general case to avoid these types of tricks.
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200623032224.4020118-3-andriin@fb.com
Diffstat (limited to 'arch/sh')
0 files changed, 0 insertions, 0 deletions