diff options
author | Marek Vasut <marex@denx.de> | 2020-03-25 15:25:47 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-03-26 20:20:19 -0700 |
commit | 8262e6f9b1034ede34548a04dec4c302d92c9497 (patch) | |
tree | cd2c6952c4fc0a9d1177254c687fd12ed8678a25 /arch/nds32 | |
parent | 328f5bb9939dc32152ae025cf5c476b4380b6215 (diff) |
net: ks8851-ml: Fix IO operations, again
This patch reverts 58292104832f ("net: ks8851-ml: Fix 16-bit IO operation")
and edacb098ea9c ("net: ks8851-ml: Fix 16-bit data access"), because it
turns out these were only necessary due to buggy hardware. This patch adds
a check for such a buggy hardware to prevent any such mistakes again.
While working further on the KS8851 driver, it came to light that the
KS8851-16MLL is capable of switching bus endianness by a hardware strap,
EESK pin. If this strap is incorrect, the IO accesses require such endian
swapping as is being reverted by this patch. Such swapping also impacts
the performance significantly.
Hence, in addition to removing it, detect that the hardware is broken,
report to user, and fail to bind with such hardware.
Fixes: 58292104832f ("net: ks8851-ml: Fix 16-bit IO operation")
Fixes: edacb098ea9c ("net: ks8851-ml: Fix 16-bit data access")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Petr Stetiar <ynezz@true.cz>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/nds32')
0 files changed, 0 insertions, 0 deletions