summaryrefslogtreecommitdiff
path: root/arch/mips/bcm63xx/dev-hsspi.c
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2016-02-05 11:22:04 +0000
committerMark Brown <broonie@kernel.org>2016-02-05 11:22:04 +0000
commit320549a22484952d88d4e0320218765b16cd2174 (patch)
tree2edd5be5c4d4a67c2ceef88be45de68ce0b3841c /arch/mips/bcm63xx/dev-hsspi.c
parent92e963f50fc74041b5e9e744c330dca48e04f08d (diff)
regmap: mmio: Revert to v4.4 endianness handling
Commit 29bb45f25ff3 (regmap-mmio: Use native endianness for read/write) attempted to fix some long standing bugs in the MMIO implementation for big endian systems caused by duplicate byte swapping in both regmap and readl()/writel() which affected MIPS systems as when they are in big endian mode they flip the endianness of all registers in the system, not just the CPU. MIPS systems had worked around this by declaring regmap using IPs as little endian which is inaccurate, unfortunately the issue had not been reported. Sadly the fix makes things worse rather than better. By changing the behaviour to match the documentation it caused behaviour changes for other IPs which broke them and by using the __raw I/O accessors to avoid the endianness swapping in readl()/writel() it removed some memory ordering guarantees and could potentially generate unvirtualisable instructions on some architectures. Unfortunately sorting out all this mess in any half way sensible fashion was far too invasive to go in during an -rc cycle so instead let's go back to the old broken behaviour for v4.5, the better fixes are already queued for v4.6. This does mean that we keep the broken MIPS DTs for another release but that seems the least bad way of handling the situation. Reported-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'arch/mips/bcm63xx/dev-hsspi.c')
0 files changed, 0 insertions, 0 deletions