diff options
author | Tony Lindgren <tony@atomide.com> | 2019-03-21 11:00:21 -0700 |
---|---|---|
committer | Tony Lindgren <tony@atomide.com> | 2019-03-26 11:26:25 -0700 |
commit | 7f0d078667a494466991aa7133f49594f32ff6a2 (patch) | |
tree | 7e4344ff562208b14f6c3a487e8b4cced1864bb6 /arch/arm/mach-imx | |
parent | 7d56bedb2730dc2ea8abf0fd7240ee99ecfee3c9 (diff) |
ARM: OMAP2+: Fix potentially uninitialized return value for _setup_reset()
Commit 747834ab8347 ("ARM: OMAP2+: hwmod: revise hardreset behavior") made
the call to _enable() conditional based on no oh->rst_lines_cnt. This
caused the return value to be potentially uninitialized. Curiously we see
no compiler warnings for this, probably as this gets inlined.
We call _setup_reset() from _setup() and only _setup_postsetup() if the
return value is zero. Currently the return value can be uninitialized for
cases where oh->rst_lines_cnt is set and HWMOD_INIT_NO_RESET is not set.
Fixes: 747834ab8347 ("ARM: OMAP2+: hwmod: revise hardreset behavior")
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Diffstat (limited to 'arch/arm/mach-imx')
0 files changed, 0 insertions, 0 deletions