summaryrefslogtreecommitdiff
path: root/Kbuild
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-08-22 23:15:47 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-08-26 18:51:50 +0200
commit505bfc2a142f12ce7bc7a878b44abc3496f2e747 (patch)
tree60497b72bf470eaeb48153897581efb6a889c787 /Kbuild
parent45c2044ccbedd48bc2a8cddde9ce7e82f03d588c (diff)
media: tuner-simple: fix regression in simple_set_radio_freq
clang static analysis reports this problem tuner-simple.c:714:13: warning: Assigned value is garbage or undefined buffer[1] = buffer[3]; ^ ~~~~~~~~~ In simple_set_radio_freq buffer[3] used to be done in-function with a switch of tuner type, now done by a call to simple_radio_bandswitch which has this case case TUNER_TENA_9533_DI: case TUNER_YMEC_TVF_5533MF: tuner_dbg("This tuner doesn't ... return 0; which does not set buffer[3]. In the old logic, this case would have returned 0 from simple_set_radio_freq. Recover this old behavior by returning an error for this codition. Since the old simple_set_radio_freq behavior returned a 0, do the same. Fixes: c7a9f3aa1e1b ("V4L/DVB (7129): tuner-simple: move device-specific code into three separate functions") Signed-off-by: Tom Rix <trix@redhat.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions