diff options
author | Jakub Sitnicki <jakub@cloudflare.com> | 2021-07-14 17:47:50 +0200 |
---|---|---|
committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-07-15 19:54:36 +0200 |
commit | 54ea2f49fd9400dd698c25450be3352b5613b3b4 (patch) | |
tree | 8fb6be135e6565195361370952b49e41b77279c7 /Documentation | |
parent | 228a4a7ba8e99bb9ef980b62f71e3be33f4aae69 (diff) |
bpf, sockmap, udp: sk_prot needs inuse_idx set for proc stats
The proc socket stats use sk_prot->inuse_idx value to record inuse sock
stats. We currently do not set this correctly from sockmap side. The
result is reading sock stats '/proc/net/sockstat' gives incorrect values.
The socket counter is incremented correctly, but because we don't set the
counter correctly when we replace sk_prot we may omit the decrement.
To get the correct inuse_idx value move the core_initcall that initializes
the UDP proto handlers to late_initcall. This way it is initialized after
UDP has the chance to assign the inuse_idx value from the register protocol
handler.
Fixes: edc6741cc660 ("bpf: Add sockmap hooks for UDP sockets")
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20210714154750.528206-1-jakub@cloudflare.com
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions