diff options
author | Steve French <sfrench@us.ibm.com> | 2006-03-31 21:22:00 +0000 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2006-03-31 21:22:00 +0000 |
commit | e9917a000fcc370408c8b7b83f2e85dba5fffbd4 (patch) | |
tree | 481bf9190677ed2b55e73625e535b86047fc5800 /Documentation/networking | |
parent | f1682e94a38b66ee2551f3a5e4b36259a561c411 (diff) |
[CIFS] Incorrect signature sent on SMB Read
Fixes Samba bug 3621 and kernel.org bug 6147
For servers which require SMB/CIFS packet signing, we were sending the
wrong signature (all zeros) on SMB Read request. The new cifs routine
to do signatures across an iovec was not complete - and SMB Read, unlike
the new SMBWrite2, did not fall back to the older routine (ie use
SendReceive vs. the more efficient SendReceive2 ie used the older
cifs_sign_smb vs. the disabled cifs_sign_smb2) for calculating signatures.
This finishes up cifs_sign_smb2/cifs_calc_signature2 so that the callers
of SendReceive2 can get SMB/CIFS packet signatures.
Now that cifs_sign_smb2 is supported, we could start using it in
the write path but this smaller fix does not include the change
to use SMBWrite2 when signatures are required (which when enabled
will make more Writes more efficient and alloc less memory).
Currently Write2 is only used when signatures are not
required at the moment but after more testing we will enable
that as well).
Thanks to James Slepicka and Sam Flory for initial investigation.
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'Documentation/networking')
0 files changed, 0 insertions, 0 deletions