summaryrefslogtreecommitdiff
path: root/CREDITS
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-11-10 13:22:15 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2015-11-10 23:46:57 +0100
commit74ec4d55c4d243330d93fc52e23e37d2e76548ba (patch)
tree5492bbb7569e0fc9ae538742c3e11f7b2bd084a0 /CREDITS
parentc872a2d9e3627829591736ddd8e8710a0afb2f95 (diff)
netfilter: fix xt_TEE and xt_TPROXY dependencies
Kconfig is too smart for its own good: a Kconfig line that states select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES means that if IP6_NF_IPTABLES is set to 'm', then NF_DEFRAG_IPV6 will also be set to 'm', regardless of the state of the symbol from which it is selected. When the xt_TEE driver is built-in and nothing else forces NF_DEFRAG_IPV6 to be built-in, this causes a link-time error: net/built-in.o: In function `tee_tg6': net/netfilter/xt_TEE.c:46: undefined reference to `nf_dup_ipv6' This works around that behavior by changing the dependency to 'if IP6_NF_IPTABLES != n', which is interpreted as boolean expression rather than a tristate and causes the NF_DEFRAG_IPV6 symbol to be built-in as well. The bug only occurs once in thousands of 'randconfig' builds and does not really impact real users. From inspecting the other surrounding Kconfig symbols, I am guessing that NETFILTER_XT_TARGET_TPROXY and NETFILTER_XT_MATCH_SOCKET have the same issue. If not, this change should still be harmless. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions