diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-05-31 12:35:32 -0500 |
|---|---|---|
| committer | Boris Brezillon <boris.brezillon@collabora.com> | 2019-07-04 12:05:14 +0200 |
| commit | ede2001569c32e5bafd2203c7272bbd3249e942e (patch) | |
| tree | 4b33f8b2533da5be34b606cb14c20faa6bfc8b8e | |
| parent | ea3bfeec6bf77033608b81a5e9a7cd6d686ab054 (diff) | |
i3c: master: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.
So, replace the following form:
sizeof(*defslvs) + ((ndevs - 1) * sizeof(struct i3c_ccc_dev_desc))
with:
struct_size(defslvs, slaves, ndevs - 1)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
| -rw-r--r-- | drivers/i3c/master.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 1318adfe0216..d6f8b038a896 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -950,9 +950,8 @@ int i3c_master_defslvs_locked(struct i3c_master_controller *master) ndevs++; defslvs = i3c_ccc_cmd_dest_init(&dest, I3C_BROADCAST_ADDR, - sizeof(*defslvs) + - ((ndevs - 1) * - sizeof(struct i3c_ccc_dev_desc))); + struct_size(defslvs, slaves, + ndevs - 1)); if (!defslvs) return -ENOMEM; |