diff options
| author | yu kuai <yukuai3@huawei.com> | 2019-12-25 21:15:20 +0800 |
|---|---|---|
| committer | Paul Burton <paulburton@kernel.org> | 2020-01-09 09:40:47 -0800 |
| commit | defed0bbca2cc24b8c2ee02d79d1451d4eb95e4a (patch) | |
| tree | 9966aed011b9c004d71ebe1ace685918b7afa161 | |
| parent | 9c48c48cd49981051fd210b7248936b65578ce31 (diff) | |
MIPS: ralink: add missing put_device in ill_acc_of_setup
If of_find_device_by_node return 0 and ill_acc_of_setup return error,
pdev don't have a corresponding object release.
Fix it by adding put_device.
Signed-off-by: yu kuai <yukuai3@huawei.com>
Signed-off-by: Paul Burton <paulburton@kernel.org>
Cc: <john@phrozen.org>
Cc: <ralf@linux-mips.org>
Cc: <jhogan@kernel.org>
Cc: <linux-mips@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Cc: <zhengbin13@huawei.com>
Cc: <yi.zhang@huawei.com>
| -rw-r--r-- | arch/mips/ralink/ill_acc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c index 0ddeb31afa93..bdf53807d7c2 100644 --- a/arch/mips/ralink/ill_acc.c +++ b/arch/mips/ralink/ill_acc.c @@ -67,11 +67,13 @@ static int __init ill_acc_of_setup(void) irq = irq_of_parse_and_map(np, 0); if (!irq) { dev_err(&pdev->dev, "failed to get irq\n"); + put_device(&pdev->dev); return -EINVAL; } if (request_irq(irq, ill_acc_irq_handler, 0, "ill_acc", &pdev->dev)) { dev_err(&pdev->dev, "failed to request irq\n"); + put_device(&pdev->dev); return -EINVAL; } |