summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2009-12-11 08:55:23 -0800
committerSage Weil <sage@newdream.net>2009-12-11 08:59:11 -0800
commitd4a780ce8821a37dd135f15b6150a5bfc5604f29 (patch)
tree677ae00e00f6d483e4cc41fe23b6dfc98bc30207
parent767ea5c33a360ce88da24e296e802dace5821799 (diff)
ceph: fix leak of monc mutex
Fix leak of monc mutex on ENOMEM or bad fsid when receiving new mon map. Audited all other users. Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r--fs/ceph/mon_client.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/ceph/mon_client.c b/fs/ceph/mon_client.c
index 1dd0dc258c50..a76da5e6dbdd 100644
--- a/fs/ceph/mon_client.c
+++ b/fs/ceph/mon_client.c
@@ -320,17 +320,18 @@ static void ceph_monc_handle_map(struct ceph_mon_client *monc,
if (IS_ERR(monmap)) {
pr_err("problem decoding monmap, %d\n",
(int)PTR_ERR(monmap));
- return;
+ goto out;
}
if (ceph_check_fsid(monc->client, &monmap->fsid) < 0) {
kfree(monmap);
- return;
+ goto out;
}
client->monc.monmap = monmap;
kfree(old);
+out:
mutex_unlock(&monc->mutex);
wake_up(&client->mount_wq);
}