diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2018-11-26 20:24:16 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-11-27 16:36:28 -0800 |
| commit | bd7153bd83b806bfcc2e79b7a6f43aa653d06ef3 (patch) | |
| tree | 3592c92bc51bf40cc2efb2cd64db9c7498310428 | |
| parent | 5d497936756fa2a917643ca688585d721dc6d31e (diff) | |
r8169: remove unneeded mmiowb barriers
writex() has implicit barriers, that's what makes it different from
writex_relaxed(). Therefore these calls to mmiowb() can be removed.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3624e67aef72..e26c48bd54a2 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -1283,13 +1283,11 @@ static u16 rtl_get_events(struct rtl8169_private *tp) static void rtl_ack_events(struct rtl8169_private *tp, u16 bits) { RTL_W16(tp, IntrStatus, bits); - mmiowb(); } static void rtl_irq_disable(struct rtl8169_private *tp) { RTL_W16(tp, IntrMask, 0); - mmiowb(); } #define RTL_EVENT_NAPI_RX (RxOK | RxErr) @@ -6127,10 +6125,8 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, if (unlikely(stop_queue)) netif_stop_queue(dev); - if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) { + if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) RTL_W8(tp, TxPoll, NPQ); - mmiowb(); - } if (unlikely(stop_queue)) { /* Sync with rtl_tx: @@ -6481,9 +6477,7 @@ static int rtl8169_poll(struct napi_struct *napi, int budget) if (work_done < budget) { napi_complete_done(napi, work_done); - rtl_irq_enable(tp); - mmiowb(); } return work_done; |