diff options
| author | Lionel Landwerlin <lionel.g.landwerlin@intel.com> | 2018-03-26 10:08:22 +0100 |
|---|---|---|
| committer | Lionel Landwerlin <lionel.g.landwerlin@intel.com> | 2018-03-29 13:30:02 +0100 |
| commit | b6dd47b9c82d619195370c38b7579fe18a8f6055 (patch) | |
| tree | 15ebeb510f4c63f6c87175862d6598a370e7c0c6 | |
| parent | 1de401c08fa805f3ac34604af1d43f48aeb17eb4 (diff) | |
drm/i915/perf: check the value of PROP_SAMPLE_OA uapi parameter
We've been a bit loose about this opening parameter. We should only
add the flag for writing OA reports when the value of this parameter
is != 0.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180326090831.22686-3-lionel.g.landwerlin@intel.com
| -rw-r--r-- | drivers/gpu/drm/i915/i915_perf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index 30444bb3aaa1..21a985bd4413 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -2746,7 +2746,8 @@ static int read_properties_unlocked(struct drm_i915_private *dev_priv, props->ctx_handle = value; break; case DRM_I915_PERF_PROP_SAMPLE_OA: - props->sample_flags |= SAMPLE_OA_REPORT; + if (value) + props->sample_flags |= SAMPLE_OA_REPORT; break; case DRM_I915_PERF_PROP_OA_METRICS_SET: if (value == 0) { |