diff options
| author | Xiubo Li <Li.Xiubo@freescale.com> | 2014-09-28 01:57:15 -0700 |
|---|---|---|
| committer | Bryan Wu <cooloney@gmail.com> | 2014-09-29 10:21:01 -0700 |
| commit | a823e76138466225d0a9f45520c5654132939a01 (patch) | |
| tree | 9c0bce385e1ec06bc173502fd59fb7a7df89b6b3 | |
| parent | 4cc72346f05ef549403d997d66fd517109e59d24 (diff) | |
led: gpio: Fix possible ZERO_SIZE_PTR pointer dereferencing error.
Since we cannot make sure the 'pdata->num_leds' will always be none
zero here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).
So this patch fix this with just doing the zero check before calling
kmemdup().
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
| -rw-r--r-- | drivers/leds/leds-gpio-register.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c index fbd89344bec4..75717ba68ae0 100644 --- a/drivers/leds/leds-gpio-register.c +++ b/drivers/leds/leds-gpio-register.c @@ -28,6 +28,9 @@ struct platform_device *__init gpio_led_register_device( struct platform_device *ret; struct gpio_led_platform_data _pdata = *pdata; + if (!pdata->num_leds) + return ERR_PTR(-EINVAL); + _pdata.leds = kmemdup(pdata->leds, pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL); if (!_pdata.leds) |