diff options
| author | Bart Van Assche <bart.vanassche@sandisk.com> | 2015-05-08 10:08:55 +0200 |
|---|---|---|
| committer | James Bottomley <JBottomley@Odin.com> | 2015-06-02 08:03:25 -0700 |
| commit | 8d3a82489107b879f7dc9b5dc6295756a2ac7806 (patch) | |
| tree | 3bc839ecbb11b264b79a45c36536e8d0047e1ac2 | |
| parent | 07e3842055c391e611dd907c81760f4c705f9acb (diff) | |
target: Correct a comment
Correct the comment above the definition of TCM_MAX_COMMAND_SIZE.
A quote from Christoph:
There aren't any legacy issues, we just decided to handle >
16 byte CDBs in the slow path.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
| -rw-r--r-- | include/target/target_core_base.h | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 480e9f82dfea..020377429043 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -17,16 +17,8 @@ /* Don't raise above 511 or REPORT_LUNS needs to handle >1 page */ #define TRANSPORT_MAX_LUNS_PER_TPG 256 /* - * By default we use 32-byte CDBs in TCM Core and subsystem plugin code. - * - * Note that both include/scsi/scsi_cmnd.h:MAX_COMMAND_SIZE and - * include/linux/blkdev.h:BLOCK_MAX_CDB as of v2.6.36-rc4 still use - * 16-byte CDBs by default and require an extra allocation for - * 32-byte CDBs to because of legacy issues. - * - * Within TCM Core there are no such legacy limitiations, so we go ahead - * use 32-byte CDBs by default and use include/scsi/scsi.h:scsi_command_size() - * within all TCM Core and subsystem plugin code. + * Maximum size of a CDB that can be stored in se_cmd without allocating + * memory dynamically for the CDB. */ #define TCM_MAX_COMMAND_SIZE 32 /* |