diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-02-03 14:29:42 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-03 17:33:01 -0500 |
| commit | 6e7bc478c9a006c701c14476ec9d389a484b4864 (patch) | |
| tree | 2a43fef8ad98fd58ad669dd84f30895e874d2df3 | |
| parent | 79e7fff47b7bb4124ef970a13eac4fdeddd1fc25 (diff) | |
net: skb_needs_check() accepts CHECKSUM_NONE for tx
My recent change missed fact that UFO would perform a complete
UDP checksum before segmenting in frags.
In this case skb->ip_summed is set to CHECKSUM_NONE.
We need to add this valid case to skb_needs_check()
Fixes: b2504a5dbef3 ("net: reduce skb_warn_bad_offload() noise")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/dev.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 4cde8bfb9bab..42ba0379575a 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2637,9 +2637,10 @@ EXPORT_SYMBOL(skb_mac_gso_segment); static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path) { if (tx_path) - return skb->ip_summed != CHECKSUM_PARTIAL; - else - return skb->ip_summed == CHECKSUM_NONE; + return skb->ip_summed != CHECKSUM_PARTIAL && + skb->ip_summed != CHECKSUM_NONE; + + return skb->ip_summed == CHECKSUM_NONE; } /** |