summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJules Irenge <jbi.octave@gmail.com>2020-08-03 13:34:38 +0100
committerPaul Moore <paul@paul-moore.com>2020-08-17 20:26:58 -0400
commit6b87024f76bc755354c18116880dc3b632447cbd (patch)
tree485ac36840b728022b372b6c13af8c10cdd1513b
parent9123e3a74ec7b934a4a099e98af6a61c2f80bbf5 (diff)
audit: change unnecessary globals into statics
Variables sig_pid, audit_sig_uid and audit_sig_sid are only used in the audit.c file across the kernel Hence it appears no reason for declaring them as globals This patch removes their global declarations from the .h file and change them into static in the .c file. Signed-off-by: Jules Irenge <jbi.octave@gmail.com> Signed-off-by: Paul Moore <paul@paul-moore.com>
-rw-r--r--kernel/audit.c6
-rw-r--r--kernel/audit.h4
2 files changed, 3 insertions, 7 deletions
diff --git a/kernel/audit.c b/kernel/audit.c
index 7efaece534a9..5cf4781d5546 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -123,9 +123,9 @@ static u32 audit_backlog_limit = 64;
static u32 audit_backlog_wait_time = AUDIT_BACKLOG_WAIT_TIME;
/* The identity of the user shutting down the audit system. */
-kuid_t audit_sig_uid = INVALID_UID;
-pid_t audit_sig_pid = -1;
-u32 audit_sig_sid = 0;
+static kuid_t audit_sig_uid = INVALID_UID;
+static pid_t audit_sig_pid = -1;
+static u32 audit_sig_sid = 0;
/* Records can be lost in several ways:
0) [suppressed in audit_alloc]
diff --git a/kernel/audit.h b/kernel/audit.h
index ddc22878433d..3b9c0945225a 100644
--- a/kernel/audit.h
+++ b/kernel/audit.h
@@ -327,10 +327,6 @@ static inline int audit_signal_info_syscall(struct task_struct *t)
extern char *audit_unpack_string(void **bufp, size_t *remain, size_t len);
-extern pid_t audit_sig_pid;
-extern kuid_t audit_sig_uid;
-extern u32 audit_sig_sid;
-
extern int audit_filter(int msgtype, unsigned int listtype);
extern void audit_ctl_lock(void);