diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-07-25 20:00:19 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-07-25 07:38:20 -0600 |
| commit | 6706ad56436c9d54c9e5812aabe25186b43b4199 (patch) | |
| tree | 4058a1ec78c0ac0a89bd1441df33ad9cca0e839f | |
| parent | 7236657c6b3abf25f8b0a2465cd8f51728d0196b (diff) | |
bcache: movinggc: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.
This code was detected with the help of Coccinelle and, audited and
fixed manually.
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/md/bcache/movinggc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/bcache/movinggc.c b/drivers/md/bcache/movinggc.c index 7891fb512736..b7dd2d75f58c 100644 --- a/drivers/md/bcache/movinggc.c +++ b/drivers/md/bcache/movinggc.c @@ -145,8 +145,8 @@ static void read_moving(struct cache_set *c) continue; } - io = kzalloc(sizeof(struct moving_io) + sizeof(struct bio_vec) - * DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS), + io = kzalloc(struct_size(io, bio.bio.bi_inline_vecs, + DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS)), GFP_KERNEL); if (!io) goto err; |